Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Angular 18 #2508

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Update to Angular 18 #2508

wants to merge 23 commits into from

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jan 7, 2025 •
edited
Loading

Pull Request

🤨 Rationale

Part of Angular 18 migration (AzDO work item)

👩‍💻 Implementation

  • bumped Angular dependency versions from 17 to 18
  • updated forked Angular files in angular-workspace/nimble-angular/src/thirdparty
    • No meaningful changes were made. In some cases I left the original imports but commented them out, rather than removing them like we had done before.

TEMPORARY (will be reverted before submission):

  • updated Angular projects to use unpublished ni-eslint-config-angular tgz
  • updated .gitignore to see .tgz file changes
  • bumped all component versions by two major versions (to ensure the built validation tgzs get used by clients even when updating branches from master)

🧪 Testing

Builds and automated tests pass

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc force-pushed the users/makinc/angular18 branch from 777d32b to ca01536 Compare January 16, 2025 23:42
@m-akinc m-akinc marked this pull request as ready for review January 17, 2025 21:52
jattasNI
jattasNI reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just want to take a quick look once it finalizes as the release train starts moving.

change/@ni-nimble-angular-b3775054-4fc0-4ca5-abdf-18a89277520c.json Show resolved Hide resolved
...s/angular-workspace/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts Show resolved Hide resolved
@m-akinc m-akinc requested a review from jattasNI January 22, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite Awaiting requested review from rajsite rajsite is a code owner

@atmgrifter00 atmgrifter00 Awaiting requested review from atmgrifter00 atmgrifter00 is a code owner

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-akinc @jattasNI @rajsite